search

sky-uk / mite

Mite - A Python Performance Testing Framework
https://sky-uk.github.io/mite/
MIT License
25 stars 7 forks source link

switch to async logging? #23

Open aecay opened 5 years ago

aecay commented 5 years ago

Currently mite uses blocking calls to the logging library to do its logging. Unfortunately, python doesn't have async logging built in. We could switch to https://github.com/B2W-BIT/aiologger for our logging. The advantage of doing so is that the log calls will be asynchronous, and play with the io model that mite uses. But it presupposes an additional dependency.

jb098 commented 4 years ago

Another fat friday task @aecay @DavAnnunz @arroncanhamskyuk, be good to do a spike and look whether it gives us a worthwhile perf boost.

aecay commented 4 years ago

👍 for a fat friday. I think this should be deferred until after the perf test suite is merged, just to make it easier to measure the impact of the change. I hope to get back to that soon, because it's (sort of) one of my PDP goals (I think I technically just committed to integration testing, not full perf tests, but one is a stepping stone to the other).