search

sky-uk / osprey

Kubernetes OIDC CLI login
BSD 3-Clause "New" or "Revised" License
50 stars 18 forks source link

use-html-parser-for-login-flow is awesome, and chance you will pull that into master #38

Open markdanko opened 5 years ago

markdanko commented 5 years ago

any plan to move use-html-parser-for-login-flow back into master.

If not, If I add a config option for use-html-parser-for-login-flow, or the default, are you likely to accept such a change to master?

mgreyo commented 5 years ago

Hey Mark,

We haven't removed any functionality, we have just added the support for authenticating via Azure AD (which in some cases has MFA, and cannot be parsed automatically for you). Apart from that, the only other change was how to start the auth server; the part that implements the "use-html-parser-for-login-flow" I think you're referencing. It is now osprey serve auth <options>.

To use it as it was previous to v2.0 you should configure the osprey: section of the config, and skip the Azure AD section, and issue the commands as usual: osprey user login.

Feel free to correct me if I'm wrong, and if you feel the README was lacking in detail please let us know!

markdanko commented 5 years ago

sorry if I am confused. my understanding is with master you need to change the dex web/static and web/themes/ (which causes other problems for me https://github.com/sky-uk/osprey/issues/20 ), but with the branch use-html-parser-for-login-flow, you do not need to. Right now, I am building/using that branch. Are you saying there is way to choose that option in master?

mgreyo commented 5 years ago

Sorry for the misunderstanding. I wasn't aware of that branch :slightly_smiling_face:

Probably one for @totahuanocotl!

totahuanocotl commented 5 years ago

Hey @markdanko, I'm very pleased to see that this has worked out for you well! I'm afraid I don't remember what the state of the branch is, I think I left it as a draft, or an initial attempt since we did not end up going up that road. I assume it has worked well for you, so I can come back and revisit it because I remember I wanted to try things a bit differently. If you are happy to wait for a couple of weeks (I'm a bit busy at the moment) I can do that for you.

Have you made any changes/improvements on your own to make it work that I should consider when working on it, or are you just using it as is?

markdanko commented 5 years ago

@totahuanocotl, A few weeks would be cool. The only change I made to that branch was back port' ing the changes in 1.5.0 about /healthz to it.