skybaks / tm-editor-helpers

Expand the map editor capabilities in Trackmania with Openplanet
https://openplanet.nl/files/69
The Unlicense
6 stars 0 forks source link

Fix for TM update of 14-12-2022 #13

Closed nbeerten closed 1 year ago

nbeerten commented 1 year ago

Fixes a newly introduced issue after the TM update of today. The error:

[    ScriptEngine] [15:15:36] [EditorHelpers]  src/EditorFunction/PodiumReminder.as (6, 9) : INFO : Compiling bool ItemContainsPodiumInfo(CGameItemModel@)
[    ScriptEngine] [15:15:36] [EditorHelpers]  src/EditorFunction/PodiumReminder.as (10, 65) :  ERR : 'PodiumInfo' is not a member of 'CGameItemModel'
[    ScriptEngine] [15:15:36]  Script compilation failed!
[    ScriptEngine] [15:15:36]  Loaded zipped plugin 'EditorHelpers' (version 5.9)

PodiumInfo no longer seems to be a member of the ItemModel, so I changed it to Name (which should always be "Podium"? but not sure if there is a better way to check if the string exists), which seems to work fine... I have no idea if it matters for the functionality, but everything seemed to work as expected (notification on save without podium placed, and no notif on save with the podium placed).

There might be more issues, but I haven't found any other than this yet.

nbeerten commented 1 year ago

Edit: Had issue with counter; Not a proper fix yet Just weird behaviour... Not yet 100% sure if its ready for release. I cannot reproduce the bug I got tho (counter shows number of all items instead of just the podium).

skybaks commented 1 year ago

It's too bad they removed the PodiumInfo :( This looks like a good solution, though.