search

skybet / cali

Cali Automation Layout Initialiser
MIT License
32 stars 7 forks source link

Static analysis fixes #43

Closed lucymhdavies closed 6 years ago

lucymhdavies commented 6 years ago

Fixes for https://github.com/skybet/cali/issues/30

Shouldn't actually affect anything.

Couple of types (docker.Event, docker.CreateResponse) have changed Id to ID... but Cali doesn't actually use those fields it seems.

The only big difference is, if you interrupt or terminate a cali app, it no longer does an os.Kill... which means the code later on in StartContainer (i.e. check exit code, delete) still tries to run... but fails, because the container no longer exists.

Ideally I'd have some better handling of this, but the whole function needs a refactor anyway.

wheresalice commented 6 years ago

I've created a little Cali app, cali-integration, to make my life easier when testing changes like this, and nothing surprising happens when I apply this change to that app.