skybet / cali

Cali Automation Layout Initialiser
MIT License
32 stars 7 forks source link

Detect if host terminal is a TTY #45

Closed lucymhdavies closed 6 years ago

lucymhdavies commented 6 years ago

Currently, the user of a cali app can manually specify that the container should be launched non-interactive: https://github.com/skybet/cali/blob/master/cli.go#L112

It should also detect if the host terminal is a TTY: https://github.com/skybet/cali/blob/master/docker.go#L241 But that doesn't quite work for some reason. Will need to port that functionality over from closed source pscli.

In both cases, we run the container non-interactive.

However, in both cases, the container is launched with DockerClient.Conf.Tty == true