skybet / cali

Cali Automation Layout Initialiser
MIT License
32 stars 7 forks source link

Megacheck is deprecated #57

Closed wheresalice closed 4 years ago

wheresalice commented 4 years ago

The current version of megacheck being used in Travis CI is deprecated, and now fails to download.

package honnef.co/go/tools/cmd/megacheck: cannot find package "honnef.co/go/tools/cmd/megacheck" in any of:
    /home/travis/.gimme/versions/go1.12.linux.amd64/src/honnef.co/go/tools/cmd/megacheck (from $GOROOT)
    /home/travis/gopath/src/honnef.co/go/tools/cmd/megacheck (from $GOPATH)
The command "go get honnef.co/go/tools/cmd/megacheck" failed and exited with 1 during .

It has been replaced with golangci-lint.

However, this new tool gives a whole bunch of errors that will fail the build:

cli.go:101:19: Error return value of `myFlags.BindPFlag` is not checked (errcheck)
        myFlags.BindPFlag("docker-host", c.Flags().Lookup("docker-host"))
                         ^
cli.go:105:19: Error return value of `myFlags.BindPFlag` is not checked (errcheck)
        myFlags.BindPFlag("debug", c.Flags().Lookup("debug"))
                         ^
cli.go:109:19: Error return value of `myFlags.BindPFlag` is not checked (errcheck)
        myFlags.BindPFlag("json", c.Flags().Lookup("json"))
                         ^
cli.go:140:22: Error return value of `myFlags.ReadInConfig` is not checked (errcheck)
        myFlags.ReadInConfig()
                            ^
docker.go:186:8: Error return value of `noGit` is not checked (errcheck)
                noGit()
                     ^
docker.go:275:25: Error return value of `terminal.Restore` is not checked (errcheck)
                defer terminal.Restore(fd, oldState)
                                      ^
docker.go:287:26: Error return value of `terminal.Restore` is not checked (errcheck)
                        defer terminal.Restore(fd, oldState)
                                              ^
git.go:122:2: ineffectual assignment to `containerName` (ineffassign)
        containerName := repoName
        ^

This issue is blocking being able to make any other changes, as it is causing all builds to fail.

wheresalice commented 4 years ago

resolved in #56