search

skyboy / NetherOres

12 stars 14 forks source link

Add support for Tinker's Construct Smeltery #4

Closed benblank closed 9 years ago

benblank commented 11 years ago

This change allows nether ores to be used in the Smeltery from Tinker's Construct. It is patterned after existing smelting/macerating support and includes the corresponding changes to the buildfile and configuration properties.

benblank commented 11 years ago

Rebased pull request to top of master; should be quick-mergable again.

skyboy commented 11 years ago

There's talk of changes to the Smeltery that would prevent this from working on both 1.6.2 and 1.6.4; I recommend instead submitting the patch to https://github.com/mDiyo/TinkersConstruct/ and using the ore dictionary entries (oreNether[Name]) to get the ores instead of having TCon include NetherOres for building.

benblank commented 11 years ago

The ore dictionary alone isn't enough to participate in the doubling mechanic, however (_smeltCount/_maceCount). Doesn't it make more sense to retain the recipes inside NO to keep that centralized and consistent?

Still, I was planning to submit a PR to TConstruct to update the MFR API anyway. I'll see if I can get up to speed on those upcoming changes and take a look at this as well.

skyboy commented 11 years ago

It makes sense, however I don't want to have two versions of NetherOres on 1.6: I don't think 1.7 is terribly far off now.

benblank commented 11 years ago

Fair enough. The question can always be re-opened once 1.7 has hit and settled down a bit. And until then, I and anyone else who wants TConstruct support can always build it from my branch.

benblank commented 9 years ago

This is well stale by now, closing.