search

skybrud / Skybrud.Essentials

Library with common purpose functionality for working with .NET.
https://packages.skybrud.dk/skybrud.essentials/
MIT License
14 stars 5 forks source link

Calling the wrong until-method? #16

Closed enkelmedia closed 3 years ago

enkelmedia commented 3 years ago

Method name does not reflect the method called?

Just wanted to let you know :)

https://github.com/skybrud/Skybrud.Essentials/blob/7859ff37e5f3e9f42a8ad3c140048cdfafcb287a/src/Skybrud.Essentials/Time/EssentialsDateTime.cs#L141

abjerner commented 3 years ago

@enkelmedia yes, this is absolutely wrong 🤦‍♂️

Thanks for reporting 👍

Anyways, the EssentialsDateTime class is actually obsolete. But I can see that I made the same mistake in the EssentialsTime class. I will look into fixing both 😉

enkelmedia commented 3 years ago

=D

I was just browsing the code as some "good night reading" yesterday and posted the issue from the phone so that I didn't forget to do it today.

=D

All the best!

abjerner commented 3 years ago

This has now been fixed 😄

43a5b6a5a7729efa56eaebdd4e79543de6f42408 adds unit tests that prove the implementation is wrong d6b11ea25dd961d1c694bf9bfda5c79ee25e9f4b ensures the correct utility method is called

Thanks for the help 👍