search

skybrud / Skybrud.Umbraco.Redirects.Import

Import and export addon for Skybrud.Umbraco.Redirects.
MIT License
7 stars 11 forks source link

Close overlays using esc key #16

Closed bjarnef closed 1 year ago

bjarnef commented 1 year ago

Which version of Skybrud.Umbraco.Redirects.Import are you using? (Please write the exact version, example: 4.0.1)

4.0.0

Which version of Skybrud.Umbraco.Redirects are you using? (Please write the exact version, example: 4.0.15)

4.0.16

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

12.2.0

Bug description

I noticed after installing following packages:

<PackageReference Include="Skybrud.Umbraco.Redirects" Version="4.0.16" />
<PackageReference Include="Skybrud.Umbraco.Redirects.Import" Version="4.0.0" />

that when import and export overlays are open, they can be closed via close link/button, butt not using esc key. They probably just need the shortcut="esc" command.

abjerner commented 1 year ago

I usually test this for overlays, but seems I may have forgotten here. Great spot 👍

bjarnef commented 1 year ago

PR submitted: https://github.com/skybrud/Skybrud.Umbraco.Redirects.Import/pull/17

I also noticed a few borgerdk CSS classes in import overlay :) The icons using <i> element could probably be replaced with <umb-icon> instead.

abjerner commented 1 year ago

Closing due to submitted PR.

Not sure if the borgerdk classes are still being used, but I will look into that 😉