search

skybrud / Skybrud.Umbraco.Redirects.Import

Import and export addon for Skybrud.Umbraco.Redirects.
MIT License
7 stars 11 forks source link

Adding Heather's code, some refactoring #2

Closed hfloyd closed 2 years ago

hfloyd commented 3 years ago

I copied over a bunch of my previous work and integrated it as best as I could for today. This all compiles, but I haven't tested it yet.

abjerner commented 3 years ago

@hfloyd sorry for the lack of reply. I meant to review this over the weekend, but ended up not having the time to do so. I'm a bit challenged on time, but I hope I'll be able to review your PR soon 😉

hfloyd commented 3 years ago

Take your time, it's all good. I try not to program much on the weekends myself 😉

~Heather

hfloyd commented 3 years ago

@abjerner - FYI - When I first submitted this, I hadn't tested it, but the later commits I added were fixes made during testing. I was able to import a file using a test webapi call (I wasn't clear how to access your UI)

twish commented 3 years ago

Any updates regarding this PR? I would love to help but have not that much insight into the package since it is the first time im using the package and this is an important thing im looking for 👍

abjerner commented 2 years ago

Hi @hfloyd

Thanks a lot for the work you've put into this 👍

As this package has always been something I've worked on a bit here and there in my spare time, my path for working on this package hasn't exactly been linear, and I think we ended up working on the same parts somewhat at the same time. So for that reason, I should probably have closed this PR back already in 2020. I'd like to have handled this a bit better, but haven't been able to due to lack of time.

Fast forward to 2022, I've now spent some time over the summer to catch up from where I left back in 2020, and I'd say I'm now very close to making an actual release.

As there has been a few major releases of Umbraco since I last worked on this, this package will target Umbraco 10 for starters, but I'll very likely also create releases for Umbraco 8 and 9. As a result of this, my work for Umbraco 10 can now be found in the v3/main branch.

The package is still not on NuGet, but hopefully I'll be able to push an alpha release of the package some time during the coming week 😎

abjerner commented 2 years ago

And it's now on NuGet: https://www.nuget.org/packages/Skybrud.Umbraco.Redirects.Import

To align the version numbers with the main redirects package, it's now V4 instead of V3 like I wrote yesterday.