search

skybrud / Skybrud.Umbraco.Redirects.Import

Import and export addon for Skybrud.Umbraco.Redirects.
MIT License
7 stars 11 forks source link

ParseRootNode using a domain returns an error "Root node with ID 'XXX' not found." #21

Closed jawood1 closed 10 months ago

jawood1 commented 10 months ago

Which version of Skybrud.Umbraco.Redirects.Import are you using? (Please write the exact version, example: 4.0.1)

4.0.1

Which version of Skybrud.Umbraco.Redirects are you using? (Please write the exact version, example: 4.0.15)

4.0.17

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

10.7.0

Bug description

This is a small bug when parsing the redirects on the method ParseRootNode the logic correctly retrieves the correct ID however it's not getting passed in to the TryGetContent method as it's calling the earlier declared variable rootNodeId rather than domain.RootContentId.Value so the value of 0 is always getting passed in.

Happy to raise a PR to resolve this

abjerner commented 10 months ago

Closing in favor of #26