Issue #19 and #21 - allowed content types and ParseRootNode from domain

skybrud / Skybrud.Umbraco.Redirects.Import

Import and export addon for Skybrud.Umbraco.Redirects.

MIT License

7 stars 11 forks source link

Issue #19 and #21 - allowed content types and ParseRootNode from domain #22

Closed jawood1 closed 10 months ago

jawood1 commented 10 months ago

Resolving the below bugs:

Please let me know if you have any feedback :)

I'm happy to extend the AllowedCsvContentTypes for additional types as per my comment on #19 but these are the two I've tested and seem to be most common so I haven't included the others as of yet.

abjerner commented 10 months ago

Hi @jawood1 and thanks for creating this PR 👍

I'd say ideally two entirely different bug fixes shouldn't be made as a single PR. Could you please split them up?

The fix for the root node ID looks good, and should be good to merge if submitted on it's own. I think I need to look a bit more into for the CSV content types are handled in order to know the correct approach.

Hope this makes sense 😉