Double import/export labels

[bjarnef]

Which version of Skybrud.Umbraco.Redirects.Import are you using? (Please write the exact version, example: 4.0.1)

4.0.1

Which version of Skybrud.Umbraco.Redirects are you using? (Please write the exact version, example: 4.0.15)

4.0.18

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

12.3.3

Bug description

I have migrated a project from Umbraco 8 > 10 > 12.

Now installed redirects package:

<PackageReference Include="Skybrud.Umbraco.Redirects" Version="4.0.18" />
<PackageReference Include="Skybrud.Umbraco.Redirects.Import" Version="4.0.1" />

But I am seeing double import/export labels here:

[abjerner]

Hi @bjarnef

This is an issue introduced in 12.3 - you can read a bit more about why this is now happening here: https://github.com/umbraco/Umbraco-CMS/commit/cb4d8e34ce9e2b124a2b1c74b4a4309ae456d64f#commitcomment-134362951

I'll keep an eye on if Mads makes a reply, or what the best approach to fix this is. Problem is that I'm specifying both a label and a label key, which now means that both are shown. If not fixed in Umbraco, I could just remove the label from my code.

[bjarnef]

Hi @abjerner

Okay, makes sense.. I will check the changes made as it used to work with label and label-key - in fact I think the label acted as fallback in case a localization didn't exist for a specific language/culture.

[abjerner]

I can see my PR to fix this in Umbraco was closed, although it may have been automatically/accidentally closed since the branch that the PR targeted was deleted.

So it might be easier just to fix this directly the this package - hence a81661a90f881ddd7622006dc91bdc5ac260ddd6

I hope to push this over the weekend as part of the v4.0.2 release 😉