skybrud / Skybrud.Umbraco.Redirects.Import

Import and export addon for Skybrud.Umbraco.Redirects.
MIT License
7 stars 11 forks source link

Umbraco 13 Support #30

Closed ahwm closed 10 months ago

ahwm commented 10 months ago

I was encountering an issue with duplicated labels that I was unable to figure out (looks like that might be coming from the main package?), but this ran on Umbraco 13 just fine otherwise.

Addresses #29

image

ahwm commented 10 months ago

Update: It looks like the main package has duplicate references and is adding the Import/Export options itself as well as from the Imports package.

When I emptied the key values, it partially updated the buttons:

<language alias="en" intName="English (US)" localName="English (US)" lcid="" culture="en-US">
  <area alias="redirects">
    <key alias="import"> </key>
    <key alias="export"> </key>
  </area>
</language>

image

EDIT: Just found the discussion in #25

abjerner commented 10 months ago

Hi @ahwm and thanks for creating this PR 👍

I just did a bunch of changes and fixes for the Umbraco 10 version of this package, and as a result of this, it was easier for me upgrade to Umbraco 13 based on this rather than accepting your PR. I hope this makes sense 😉

Anyways - a few comments regarding your PR:

ahwm commented 10 months ago

Sounds great! It just didn't seem like there was any activity here. I assumed it might have had to do with that bug or something else going on in the background. Just happy the update is out!