Closed ahwm closed 10 months ago
Update: It looks like the main package has duplicate references and is adding the Import/Export options itself as well as from the Imports package.
When I emptied the key values, it partially updated the buttons:
<language alias="en" intName="English (US)" localName="English (US)" lcid="" culture="en-US">
<area alias="redirects">
<key alias="import"> </key>
<key alias="export"> </key>
</area>
</language>
EDIT: Just found the discussion in #25
Hi @ahwm and thanks for creating this PR 👍
I just did a bunch of changes and fixes for the Umbraco 10 version of this package, and as a result of this, it was easier for me upgrade to Umbraco 13 based on this rather than accepting your PR. I hope this makes sense 😉
Anyways - a few comments regarding your PR:
the duplicate labels are caused by a bug introduced in Umbraco 12. It has yet to be fixed in Umbraco, so I've now addressed this in this package instead. This has now been fixed for the Umbraco 10 package (which also supports Umbraco 12) as well as the new Umbraco 13 package
it seems that you have to be extra careful when upgrading the ClosedXml
dependency. I don't think I've upgraded the dependency where there hasn't been a breaking change. This is also the case when going from 0.101.0
to 0.102.1
or now 0.102.2
. The code would still compile, but when trying to read the cell value, the GetText
method would throw an exception about an invalid cast. You can see the fix here.
as of Umbraco 13, we'll be aligning our the major version of our packages with Umbraco, so which is why I've now release a v13.0.0
instead of a v5.0.0
. This is done to better illustrate which Umbraco version a major version of one of our packages support.
Sounds great! It just didn't seem like there was any activity here. I assumed it might have had to do with that bug or something else going on in the background. Just happy the update is out!
I was encountering an issue with duplicated labels that I was unable to figure out (looks like that might be coming from the main package?), but this ran on Umbraco 13 just fine otherwise.
Addresses #29