search

skybrud / Skybrud.Umbraco.Redirects

Redirects manager for Umbraco.
https://packages.limbo.works/skybrud.umbraco.redirects/
MIT License
38 stars 43 forks source link

Umbraco 14 progress #208

Open abjerner opened 3 months ago

abjerner commented 3 months ago

Branch: v14/main

Features

Known issues

nifvi commented 1 month ago

Hi @abjerner!

I'm sorry to bother you with my tedious question, but do you have a timeframe on when you think your Plugin might be ready for a release for Umbraco 14?

abjerner commented 1 month ago

Hi @nifvi

To be honest I haven't really looked at the U14 package for the last couple of months. It's not currently something I have the time to work on during business hours, and I also haven't had the time or energy to work on the package in my spare time.

Besides, Umbraco 14 also still feels very unfinished, and I still see it as a pre release although Umbraco hasn't released it as such. For one, Skybrud Redirects uses Umbraco's link picker modal, but the modal is broken. I just had a check, and Umbraco made some changes to it in 14.2, which then breaks the current alpha of Skybrud Redirects, as my package relies on how the link picker modal worked in 14.0 and 14.1. But the modal is still broken in 14.3 RC. So my issue https://github.com/umbraco/Umbraco-CMS/issues/16838 still hasn't been addressed.

I should be able to find a bit of time to push a new alpha with a fix for Umbraco's breaking change. But I can't say when I work on the missing features listed in the beginning of this issue.

nifvi commented 1 month ago

Hi Anders,

Thank you for your honest and thorough response to my inquiry. I agree with your assessment of umbracos 14 state and do hope that they fix things that will make it feasible to upgrade.

My client wants to add a dashboard and functionality to the back office but I can’t recommend this as it’s still umbraco 13 but a move to 14 wouldn’t be a good move right now anyway.

I hope you will have the opportunity in future to work on this really great and important project.

Thanks for sharing your status and for your time

Bedste hilsener,

Nicklas Folden Vind Senior software udvikler, Byteable ApS

www.byteable.dev +45 23277907 <+4523277907>

søn. 22. sep. 2024 kl. 18.18 skrev Anders Bjerner @.***

:

Hi @nifvi https://github.com/nifvi

To be honest I haven't really looked at the U14 package for the last couple of months. It's not currently something I have the time to work on during business hours, and I also haven't had the time or energy to work on the package in my spare time.

Besides, Umbraco 14 also still feels very unfinished, and I still see it as a pre release although Umbraco hasn't released it as such. For one, Skybrud Redirects uses Umbraco's link picker modal, but the modal is broken. I just had a check, and Umbraco made some changes to it in 14.2, which then breaks the current alpha of Skybrud Redirects, as my package relies on how the link picker modal worked in 14.0 and 14.1. But the modal is still broken in 14.3 RC. So my issue umbraco/Umbraco-CMS#16838 https://github.com/umbraco/Umbraco-CMS/issues/16838 still hasn't been addressed.

I should be able to find a bit of time to push a new alpha with a fix for Umbraco's breaking change. But I can't say when I work on the missing features listed in the beginning of this issue.

— Reply to this email directly, view it on GitHub https://github.com/skybrud/Skybrud.Umbraco.Redirects/issues/208#issuecomment-2366858782, or unsubscribe https://github.com/notifications/unsubscribe-auth/BH63Z34T4CBCGQUBSP74WOLZX3UVPAVCNFSM6AAAAABLOUE3FGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRWHA2TQNZYGI . You are receiving this because you were mentioned.Message ID: @.***>

leekelleher commented 3 weeks ago

@abjerner Whilst feedbacking back on the issues you raised, I wanted to take a look at how you were getting on with porting to v14.

As you mentioned, there are some blockers, (in core), but I did make some small progress. I've got my changes in a forked branch: https://github.com/skybrud/Skybrud.Umbraco.Redirects/compare/v14/main...leekelleher:umbraco-skybrud-redirects:v14/bugfix/url-picker-modal

I didn't make a PR for these, as I wasn't sure what you want the minimum Umbraco dependency to be, (for my changes it'd need to be v14.2+). Plus knowing that there are further fixes (in core) coming soon, I didn't want to confuse matters. Still, I wanted to share my code changes with you.

abjerner commented 3 weeks ago

@leekelleher thanks for getting back to me 👍

I haven't really looked must at the package due to general busyness, but I did notice the link picker was added to the import maps in 14.2.

I have worked on updating my package to reflect this, but so far, it hasn't made it anywhere beyond my disk. I should probably start with looking into how far i got, and then have a look at your other changes.