Refactoring old Redux remnants into a consistent structure based on feature slices

skybrush-io / live

An open-source drone show and drone swarm ground control station GUI frontend

https://skybrush.io

GNU General Public License v3.0

52 stars 38 forks source link

Refactoring old Redux remnants into a consistent structure based on feature slices #12

Closed ntamas closed 2 years ago

ntamas commented 2 years ago

Sending a PR so I can do a formal review

Summon @Isti115

ntamas commented 2 years ago

Roughly halfway through the review (50/96 files viewed), no big issues so far, looks great!

ntamas commented 2 years ago

All is good I think; the only significant change I've made is this one. I believe the original updeep call also used a shallow clone, but even if it didn't, I think a shallow clone is more appropriate here.