skybrush-io / live

An open-source drone show and drone swarm ground control station GUI frontend
https://skybrush.io
GNU General Public License v3.0
52 stars 38 forks source link

Control panels are blocked by "SHOW AUTHORIZED TO START" button. #38

Closed kazogihara closed 1 year ago

kazogihara commented 1 year ago

Hello. I would like to mention an issue, a small one on the screen display, that I have been wondering about.

Steps to reproduce

  1. Make "Show control" so small in height that control panels will not fit.
  2. Click "SHOW AUTHORIZED TO START" button.
  3. Scroll down to the bottom of the control panel.

Expected result

Additional information

  1. Commit Hash
    • 95249aa5
  2. Browser
    • Chrome 118.0.5993.71
  3. image image
ntamas commented 1 year ago

I've made some adjustments to the layout in adba06a7; in particular, the visual glitch that you made a screenshot of does not happen any more and the "Show authorized to start" button stays attached to the bottom of the panel. I've also decreased the line height in the large colored buttons so there is less space between the icon and the label, allowing the buttons to fit better when the space is limited.

The "Show authorized to start" button will nevertheless stay on top of the button panel - that was a conscious design decision. What has changed now is that the upper part of the panel holding the large colored buttons is scrollable while it allows the "Show authorized to start" button to stay attached to the bottom of the panel.

Please give it a go and let me know whether this fixes your problem.

kazogihara commented 1 year ago

Thanks for rapid reply! As you said, this has already been resolved. image