skycoin / dmsg

dmsg
7 stars 17 forks source link

Integrate Uptime Tracker with Dmsg Discovery - deprecate dmsg client monitor #291

Open 0pcom opened 1 month ago

0pcom commented 1 month ago

The dmsg client monitor implementation was plagued with issues resulting from the fact that the monitor assumed the dmsg client to be a visor when it may not be a visor.

In order to have an accurate list of dmsg client entries in the dmsg-discovery, we should consider integrating the uptime tracker with the dmsg discovery.

There is no way to verify externally via querying a dmsg client entry that the client is online or not ; because there isn't no single endpoiint like /health served by the client over dmsg.

Its possible that dmsg client entries are currently expired after 5 minutes without re-registration. This logic should be verified. If dead entries are currently present, it would make sense to integrate the uptime tracker and the dmsg discovery.