Update crypro library with Bitcoin operations

skycoin / hardware-wallet

Firmware and Bootloader for the Skywallet.

https://www.skycoin.com/

11 stars 9 forks source link

Update crypro library with Bitcoin operations #44

Closed Midren closed 4 years ago

Midren commented 5 years ago

For Bitcoin integration, we need to add all crypto-related functions, that are needed for Bitcoin but are not used in Skycoin. We need to use the functions from trezor implementation to be sure, that they work well

[x] Investigate which functions should be added to our crypto library
[ ] Add them to our library
[ ] Write tests to be sure, that they are working well.

Macrosrider commented 4 years ago

At the moment, there is no reason to update crypto library, because all crypto, we need, is already implemented. But:

BTC address generation method is a bit different (actually, the order of hashing and version byte positions are different)
There is no P2PKH or P2SH in Skycoin
For transaction signing, Skycoin use Binary encodind, BTC use DER encoding instead. But, in skycoin-api/tools/ecdsa.c there is ecdsa_sig_to_der() function, which convert Binary encoding to DER