search

skycoin / services

Incubator repo for various services
16 stars 25 forks source link

CI working for every project inside the repository? #107

Closed ivcosla closed 6 years ago

ivcosla commented 6 years ago

So I made that Pull Request https://github.com/skycoin/services/pull/102 which won't pass the CI test. It only contains changes to the Gopkg.toml, so with the right settings the CoinApi project compiles now. But the CI will get my PR rejected.

The way the CI is working with this project is right?, there is only one CI performing the same checks for every project inside this repository?.

nutmix commented 6 years ago

There are many projects in services. Travis is only designed to build a single project. Currently the travis is not setup to build each project, but is kicked of by changes to any project. It may be possible to create a travis build which checks which services sub-projects have changed, and only builds that project.

ivcosla commented 6 years ago

May it be a temporary workaround to just disable the checks when the changes belong to other projects?.

Right now most of these projects doesn't even have tests, and the ones that have are not doing a significant coverage or actual unit testing.

In the future they should have of course, and the CI will have to check they pass.