Open evanlinjin opened 5 years ago
@evanlinjin note that uptime only requires the time elapsed since the last connection to the discovery (ap4y suggested implementing uptime tracking in transport discvory). The total uptime is calculated by the monitor, although we could improve on that.
Could you elaborate on why you want to move the RPC implementation back to /pkg/node?
@evanlinjin note that uptime only requires the time elapsed since the last connection to the discovery (ap4y suggested implementing uptime tracking in transport discvory). The total uptime is calculated by the monitor, although we could improve on that.
Could you elaborate on why you want to move the RPC implementation back to /pkg/node?
For the first point, it's the transport discovery right? I think we need to call it network-uptime
otherwise it will be confused with how long the node software has been running.
For the second point, it makes more sense to have it there and leads to more confusion.
small correction, I actually backtracked suggestion for using transport discovery for uptime, see issue 110 in the original repo. My idea was to use transports to track uptime, since they have statuses but as I mentioned in that issue it's not going to work. Having separate service makes the most for me but I think it was rejected as an idea.
Description
This is a parent issue of multiple sub-issues/sub-PRs. This is provided here for a clear overview of tasks.
From @jdknives on Discord:
Tasks
/pkg/node
module.