search

skycoin / skywire-testnet

Skywire Meshnet and VPN
https://skycoin.net/skywire
162 stars 63 forks source link

dmsg hypervisor #563

Open ivcosla opened 5 years ago

ivcosla commented 5 years ago

Working state, integration tests are working, but hypervisor tests need fix.

ivcosla commented 5 years ago

Closes #560

evanlinjin commented 5 years ago

Btw, will be good if you can provide steps of how this can be tested.

ivcosla commented 5 years ago

This can be tested with skywire-services on feature/dmsg-hypervisor branch. Then: 1) make integration-build 2) make integration-run-generic

From now on you can test the hypervisor API, for example you can curl localhost:8080/api/nodes

ivcosla commented 5 years ago

Note however that by removing noise.RPCClientDialers now there is no retrial in the Dial operation between visor and hypervisor. It could be added if deemed necessary in line https://github.com/skycoin/skywire/pull/563/files#diff-8b79394cd85c849e746408355107d3b6R241 using an netutil.Retrier.

evanlinjin commented 5 years ago

make integration-build

Where is the endpoint documentation kept? Are we still updating this Postman file?

https://github.com/skycoin/skywire/blob/mainnet-milestone2/cmd/hypervisor/hypervisor.postman_collection.json

ivcosla commented 5 years ago

make integration-build

Where is the endpoint documentation kept? Are we still updating this Postman file?

https://github.com/skycoin/skywire/blob/mainnet-milestone2/cmd/hypervisor/hypervisor.postman_collection.json

I didn't update it, will do it as part of the requested changes.

evanlinjin commented 5 years ago

@ivcosla Just gave it a test run and it is working very well. Please fix the last request, thank you.