search

skycoin / skywire

Skywire Node implementation
72 stars 45 forks source link

separate survey collection from transport bandwidth logging collection #1657

Open 0pcom opened 1 year ago

0pcom commented 1 year ago

Currently the survey and transport bandwidth logs are collected from only visors which met 75% uptime for the previous day.

This is ok for surveys, however we need to collect transport bandwidth logging for all visors, regardless of their having made uptime.

The transport bandwidth logging should be collected from any visor which is currently online and should be preceded by a check of the /health endpoint of the dmsghttp log server.

We have a framework in place already for skywire-cli log which can do this.

we only need to implement this change on the reward system server.

0pcom commented 3 months ago

What we really need for this is an endpoint on the transport discovery to show transports which have existed in the past day. Then the transport bandwidth logging may be collected in a more targeted way from the specific visor public keys which actually had transports over the past day.

However, we actually should not do this.

Instead, what we should do is make the visor report the transport bandwidth logging to the transport discovery server periodically and on closure of the transport. Then, the reward system can fetch the logging from there and display it, obviating the need for it to be collected directly.

see issue https://github.com/skycoin/skywire/issues/1758