skycoin / skywire

Skywire Node implementation

73 stars 45 forks source link

inconsistent flag format for apps config #1707

Closed 0pcom closed 4 months ago

0pcom commented 6 months ago

It appears that we use flags inconsistently (in some cases incorrectly) for the apps, currently.

I'm not sure why we haven't noticed errors from this yet.

The way the code is currently on develop, the apps use the "flags" package, which accepts flags in the format -flag and not --flag

here it's in the single hyphen format https://github.com/skycoin/skywire/blob/develop/pkg/visor/visorconfig/config.go#L247

but in pkg/visor/api we use the double hyphen format in some places and single hyphen in other places https://github.com/skycoin/skywire/blob/develop/pkg/visor/api.go#L777 https://github.com/skycoin/skywire/blob/develop/pkg/visor/api.go#L797

1704 addresses this

0pcom commented 4 months ago

fixed in #1704