Service discovery should not return keys for offline visors - Githubissues

skycoin / skywire

Skywire Node implementation

73 stars 45 forks source link

Service discovery should not return keys for offline visors #1715

Closed 0pcom closed 4 months ago

0pcom commented 6 months ago

When attempting to test the proxy, it seems not all the keys returned from the service discovery query are actually online.

Suggested fixes:

consider adding a monitor of the proxy service discovery / proxy servers
fix the vpn server monitor
devise a way to keep from presenting keys to the user from skywire-cli proxy list or skywire-cli vpn list which are not online.
consider how to expire keys from service discovery, or have the visor re-register its services with SD at set intervals, perhaps hourly

0pcom commented 4 months ago

This was addressed with client-side filtering of the keys returned from service discovery, with an additional query to the uptime tracker.