skycoin / skywire

Skywire Node implementation
73 stars 45 forks source link

Merged binary for Windows and Mac #1769

Closed mrpalide closed 3 months ago

mrpalide commented 3 months ago

Feature description As we implemented recently merged binary for linux, then be good if we have same situation for Windows and Mac.

mrpalide commented 3 months ago

Based on this comment (here) from logrus collaborator, the github.com/sirupsen/logrus/hooks/syslog package could not build on Windows at all, so we don't have any chance to have skywire-deployment merged binary file on Windows. So we keep Windows and MacOS build/binary/installer file at current logic and continue with separated apps.

0pcom commented 3 months ago

it should still be possible to compile https://github.com/skycoin/skywire/blob/master/cmd/skywire/skywire.go on both windows and mac

If it still won't build because of this

"The github.com/sirupsen/logrus/hooks/syslog package will not build on Windows, Plan9, and nacl because the entirety of it is behind a set of build constraints (via build tags) that prevent it from being compiled on those platforms."

Then we should simply remove the syslog because it's totally unused AFAIK