command "del_term" argument bugs

skycoin / viscript

10 stars 6 forks source link

command "del_term" argument bugs #136

Closed corpusc closed 7 years ago

corpusc commented 7 years ago

when feeding values of 0-2 (and 2 terminals listed):

"2" crashed
higher numbers said they were invalid (including verified correct numbers). and should use standardized error message format
"0" & "1" gave no feedback and did nothing

corpusc commented 7 years ago

The 3 situations I initially listed SHOULD be FIXed now.

However there are more bugs:

Any valid friendly ID that user gives is passed as THE SAME (therefore sometimes wrong) msg.TerminalId.
Doesn't ever actually remove anything.
Needs to unsubscribe to cleanup/clear DbusGlobal.

corpusc commented 7 years ago

FIXED one bug (passes the correct ID all the way through to TerminalStack.Remove().

I encountered very weird behaviour with delete() never working. I made code to verify that the terminal id was in the TermMap.

However when checking by asking the map if a key exists it ALWAYS claims it doesn't exist.

Whereas when I iterate through the Terminal map, and compare the passed id against each one, it always matches with one of the map entries.

corpusc commented 7 years ago

Fixed the wrong terminal id being passed (awhile back).

I'm gonna rework this whole thing to work similar to how the "focus" command works. So there is no need to list terminals in GL mode (or use a sequential id from the list, which is different from the Terminal's id).

corpusc commented 7 years ago

now you can give the terminal id as 1 or more digits (which must match that many of the leftmost digits of the "TerminalId"s which show in the graphic tab, and the now-more-simple "list_terms" feedback).

corpusc commented 7 years ago

closes the terminal

corpusc commented 7 years ago

removes Task from GlobalTasks list
removes Termnal from TerminalStack list
removes channels for both of them in the dbus