search

skycrafters / responder

The Responder is a tool that aims to provide a simple framework to respond to any events in the cloud
https://skycrafters.io
Apache License 2.0
17 stars 5 forks source link

Replace Blacklist/Whitelist with Allow/Deny entries #2

Closed keinu closed 3 years ago

keinu commented 3 years ago

Update the default rule configuration for AWS/UnauthorizedInstanceCreated to have a more inclusive allowedInstances and deniedInstances name instead of whiteListedInstances and blackListedInstances

https://github.com/skycrafters/responder/blob/76c4c9c0884197872bbeb55e299f528a8f104145/rules/AWS/UnauthorizedInstanceCreated/config-default.yml#L9

magnologan commented 3 years ago

Is it just about changing the names on the YAML file or there are more things involved? 🤔

keinu commented 3 years ago

@magnologan, the isValid function below has to be updated to reflect the changes in the YAML file https://github.com/skycrafters/responder/blob/daf7ba9dd9ecd319faee0ee6711e62b57be20ffc/rules/AWS/UnauthorizedInstanceCreated/index.js#L75

magnologan commented 3 years ago

Done! =)

https://github.com/skycrafters/responder/pull/12