Speeding up of std::string parameters

skydevgit / crisscross

Automatically exported from code.google.com/p/crisscross

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Speeding up of std::string parameters #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

In order to avoid unnecessary invoking of the copy constructor, std::string 
parameters should be 
passed as constant references (const std::string&).

Original issue reported on code.google.com by ARPl...@gmail.com on 18 May 2007 at 6:02

GoogleCodeExporter commented 9 years ago

Shouldn't copy it, since it's reference counted, but I agree. Should be const
std::string&.

Since this breaks binary compatibility, targeting for v0.7.

Original comment by steven.n...@gmail.com on 18 May 2007 at 6:28

Changed state: Accepted
Added labels: Milestone-Release0.7

GoogleCodeExporter commented 9 years ago

Change committed to trunk, will be merged in time for v0.6.1.

Original comment by steven.n...@gmail.com on 20 May 2007 at 9:13

Added labels: Milestone-Release0.6
Removed labels: Milestone-Release0.7

GoogleCodeExporter commented 9 years ago

Merged in 0.6 branch r356.

Original comment by steven.n...@gmail.com on 20 May 2007 at 9:36

Changed state: Verified