skydevgit / crisscross

Automatically exported from code.google.com/p/crisscross
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Separate interface from implementation #17

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Implementation details should be separated from the interface. Most notably, 
RedBlackTree violates 
this rule with its name: if a faster tree structure was discovered, the class 
would have to be 
renamed. BTree, or even just Map would be better names. (same with other such 
matters)

Original issue reported on code.google.com by ARPl...@gmail.com on 18 May 2007 at 6:03

GoogleCodeExporter commented 9 years ago
Agreed. BTree would be appropriate naming.

Targeting for v0.7

Original comment by steven.n...@gmail.com on 18 May 2007 at 6:31

GoogleCodeExporter commented 9 years ago
I've used a preprocessor macro to alias BTree to mean RedBlackTree. I've done 
this
because I may have many different tree classes, and the default will just be 
set to
RedBlackTree.

Change committed in trunk. Will be merged in time for v0.6.1.

Original comment by steven.n...@gmail.com on 20 May 2007 at 9:16

GoogleCodeExporter commented 9 years ago
Merged in 0.6 branch r356.

Original comment by steven.n...@gmail.com on 20 May 2007 at 9:37