skydive-project / skydive

An open source real-time network topology and protocols analyzer
https://skydive.network
Apache License 2.0
2.68k stars 404 forks source link

go.sum is present in the repo and in .gitignore #2384

Closed adrianlzt closed 8 months ago

adrianlzt commented 3 years ago

This commit added go.sum to the .gitignore file (2021/2/1). @hunchback error?

The go.sum file was deleted here by @lebauce (2019/11/12) and added back here by @amorenoz (2021/07/15).

So, with or without?

lebauce commented 3 years ago

Theoretically, go.sum should be part of this repository but I still having troubles understanding why the content differs from one machine to an other, causing the go-fmt test to fail so I ended up removing it. Now that Go modules are a bit more stable, we should probably add it back

lebauce commented 8 months ago

This is now fixed. go.sum is tracked by Git and removed from .gitignore