search

skydive-project / skydive

An open source real-time network topology and protocols analyzer
https://skydive.network
Apache License 2.0
2.65k stars 400 forks source link

ES detect partial failures #2386

Closed adrianlzt closed 3 years ago

adrianlzt commented 3 years ago

This commmit modify Search method to return an error if any shard has failed.

If some shards are failing in a ES query, the "Do()" method could return no error. Those errors will be in res.Shards.Failures

lebauce commented 3 years ago

Thank you ! It seems that go.mod needs to be updated with the new lib. Otherwise LGTM

lebauce commented 3 years ago

@adrianlzt It seems you commited a temporary analyzer/server_easyjson.go

adrianlzt commented 3 years ago

Sorry, fixed!

lebauce commented 3 years ago

It seems that you need to apply :

diff --git a/go.mod b/go.mod
index a11e11a9..9b18b8f3 100644
--- a/go.mod
+++ b/go.mod
@@ -31,7 +31,6 @@ require (
        github.com/gorilla/mux v1.8.0
        github.com/gorilla/websocket v1.4.2
        github.com/gosuri/uitable v0.0.0-20160404203958-36ee7e946282 // indirect
-       github.com/hashicorp/go-multierror v1.0.0 // indirect
        github.com/hashicorp/golang-lru v0.5.3
        github.com/hydrogen18/stoppableListener v0.0.0-20151210151943-dadc9ccc400c
        github.com/inconshreveable/log15 v0.0.0-20201112154412-8562bdadbbac // indirect
adrianlzt commented 3 years ago

Sorry for the mess :(

lebauce commented 3 years ago

run k8s-tests run scale-tests

lebauce commented 3 years ago

@adrianlzt Don't be ! go modules are a mess :-) Thank you for your contributions

lebauce commented 3 years ago

run k8s-tests run scale-tests