search

skydive-project / skydive

An open source real-time network topology and protocols analyzer
https://skydive.network
Apache License 2.0
2.68k stars 404 forks source link

Submodule is not tagged properly #2449

Open HappyHacker123 opened 2 months ago

HappyHacker123 commented 2 months ago

I found that module github.com/skydive-project/skydive/graffiti is a submodule of skydive.

However, it seems that submodule github.com/skydive-project/skydive/graffiti is not tagged. According to Go Modules standard , submodule should be tagged like relative-path-to-root/vX.X.X. At present, when trying to import the package, downstream project would have to depend on pseudo-version of it and cannot get a valid tag version.

require github.com/skydive-project/skydive/graffiti v0.0.0-20240717134610-a4452f214754

Would you consider tagging the submodule according to Go standard, for example, releasing a tag `graffiti/v0.28.0``, so that we can use tag version to import this module in go.mod?

HappyHacker123 commented 2 months ago

@lebauce Could you please take a look at this issue? Many thanks :)