search

skydiver / october-plugin-forms

Create easy (and almost magic) AJAX forms
https://octobercms.com/plugin/martin-forms
MIT License
60 stars 41 forks source link

fix for broken js file inclusion #215

Closed mjauvin closed 4 years ago

mjauvin commented 4 years ago

apply fix suggested by Samuel Georges (@daftspunk)

fixes #213

LukeTowers commented 4 years ago

@mjauvin I don't know if this will work because it doesn't evaluate the twig. You should be able to just rename the files to have .htm extensions though

mjauvin commented 4 years ago

You're right.

skydiver commented 4 years ago

@LukeTowers and @mjauvin

it's not enough to load a plain html with all the javascript code inside a <script></script> tag?

LukeTowers commented 4 years ago

@skydiver What do you mean?

skydiver commented 4 years ago

update: i saw the problem, i think @mjauvin solution should work, it's called .js just because there is javascript code, but the content is inserted into an html file ... so should work