search

skydoves / Balloon

:balloon: Modernized and sophisticated tooltips, fully customizable with an arrow and animations for Android.
https://skydoves.github.io/libraries/balloon/html/balloon/com.skydoves.balloon/index.html
Apache License 2.0
3.69k stars 289 forks source link

showAlignTop not respected #78

Closed ezefire closed 4 years ago

ezefire commented 4 years ago

Please complete the following information:

Describe the Bug:

I'm using showAlignTop and showAlignBottom but it seems sometimes it is not respected and the balloon is shown in other position.

Expected Behavior:

The balloon is shown where I indicate

skydoves commented 4 years ago

Hi, @ezefire! Could you explain more details about the issue or sample project? I guess If there is not enough space for showing the balloon over the target view, the balloon will not show exactly on the top.

ezefire commented 4 years ago

Hi @skydoves, I've made a logic to make the balloon appear where there is more space to be shown. I see where is positioned my target view in the screen at the moment of showing the balloon and bassed on that i use showAlingTop or showAlignBottom. After that, even if there is more space at the top than at the bottom the balloon is shown at the bottom.

This issue is related to #68 because due to the need to set the arrow orientation we need to show the balloon acording to it. If we don't do that the balloon could be shown with a wrong position of the arrow.

skydoves commented 4 years ago

Hi, @ezefire! It is released in the new release 1.2.1. Please check the issue still happening if using the new functions. Thank you for your issue.