search

skydoves / Pokedex

🗡️ Pokedex demonstrates modern Android development with Hilt, Material Motion, Coroutines, Flow, Jetpack (Room, ViewModel) based on MVVM architecture.
Apache License 2.0
7.76k stars 1.03k forks source link

pokemon types are not displayed properly #5

Closed thatfiredev closed 4 years ago

thatfiredev commented 4 years ago

Please complete the following information:

Describe the Bug:

The pokemon types are not being displayed properly on my device. Here's a screenshot:

screenshot_vertical

~Also, after rotating the device to landscape mode, the types are duplicated:~ (See comment bellow)

screenshot_horizontal

Expected Behavior:

Expected pokemon types to be displayed exactly like the screenshots on the repo.

thatfiredev commented 4 years ago

Update 1: Tested this on a Pixel 2 emulator running Android 8.1 and it is displayed correctly ~, but the rotation error is still there.~

Update 2: The rotation error was fixed by https://github.com/skydoves/Pokedex/commit/51de2a222d96903efde2603fddce5ac96e45334b

npace commented 4 years ago

Similar problem on a Samsung A40 (Android 10): image

skydoves commented 4 years ago

@npace Hi, could you please run the project again after pulling new commits?

thatfiredev commented 4 years ago

I can confirm it now works fine after pulling the latest commits. We can close this once @npace confirms it works on his device

skydoves commented 4 years ago

This issue seems fixed on the latest commits. Thank you for contributing issue :)