skydoves / PowerMenu

:fire: Powerful and modernized popup menu with fully customizable animations.
Apache License 2.0
1.19k stars 175 forks source link

Fix focus state #97

Closed sebastienrouif closed 1 year ago

sebastienrouif commented 1 year ago

🎯 Goal

When launching a menu, it currently does get focus which makes it impossible to access when using keyboard navigation

🛠 Implementation details

I simply set the window to be focusable

✍️ Explain examples

Example is no navigable through keyboard when using .isFocusable

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Then dump binary APIs of this library that is public in sense of Kotlin visibilities and ensures that the public binary API wasn't changed in a way that makes this change binary incompatible.

./gradlew apiDump

Please correct any failures before requesting a review.

Code reviews

All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult GitHub Help for more information on using pull requests.

sebastienrouif commented 1 year ago

resolves https://github.com/skydoves/PowerMenu/issues/81

sebastienrouif commented 1 year ago

Thanks @skydoves , could you release a snapshot or full version ?

sebastienrouif commented 1 year ago

@skydoves I can't find the snapshot version on maven, is the snapshot release working? otherwise would you mind starting a release ?

skydoves commented 1 year ago

Hey @sebastienrouif, sorry for the late response. I will release the next stable version this week and let you know soon! And thank you so much for your contribution :)

skydoves commented 1 year ago

Btw you can import the snapshot version below:

implementation "com.github.skydoves:powermenu:2.2.2-SNAPSHOT"

Also, please make sure you added the snapshot repository below on your maven settings.

maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' }
sebastienrouif commented 1 year ago

I was missing the second part

sebastienrouif commented 1 year ago

sorry to bother you, I was hopping to include a stable version of the library this week