search

skydoves / PowerSpinner

🌀 A lightweight dropdown popup spinner, fully customizable with an arrow and animations for Android.
Apache License 2.0
1.2k stars 114 forks source link

Request: improve animation when opening/closing #2

Closed AndroidDeveloperLB closed 4 years ago

AndroidDeveloperLB commented 4 years ago

Is your feature request related to a problem? Seems in the sample animations that it scales the list in animation, so the items look squeezed :

https://i.imgur.com/R8wPZXW.png

Describe the solution you'd like: On the native one, it doesn't scale, so it shows nicely (play in super slow motion) :

https://www.youtube.com/watch?v=on_OrrX7Nw4

Describe alternatives you've considered: Use native one?

skydoves commented 4 years ago

@AndroidDeveloperLB Hi, I already noticed it and I resolved it via fading effect instead of scale down.

After: https://user-images.githubusercontent.com/24237865/71558150-3cfd1700-2a93-11ea-9809-ce33309ebc96.gif

Thank you for your issue and interest! :)

AndroidDeveloperLB commented 4 years ago

I don't see it fixed on your gif animation:

image

skydoves commented 4 years ago

@AndroidDeveloperLB

Ah, I thought you meant items being squeezed when it is disappearing. I was thinking the scaling animation makes more dynamically the popup but it could seem weird in some cases. I will add Normal type of SpinnerAnimation. Thank you!

AndroidDeveloperLB commented 4 years ago

I'm talking about both appearing and disappearing. Can you please have the same animation as on the native spinner? I don't think it's scale animation. If you look at the video, you will see that all texts are shown well and not stretched while animating. I think it's some reveal-animation instead.

skydoves commented 4 years ago

@AndroidDeveloperLB Yes. I just added a normal type. https://user-images.githubusercontent.com/24237865/71888721-14a4a500-3184-11ea-9d47-a744229577f2.gif

It is released on version 1.0.3.

AndroidDeveloperLB commented 4 years ago

I think it's nicer.

AndroidDeveloperLB commented 4 years ago

I suggest to update the animations of the repository, and make this the default animation .

skydoves commented 4 years ago

@AndroidDeveloperLB Hi, the NORMAL type animation is already the default animation after the lastest version 1.0.3. You can reference here: Arrbitues.

AndroidDeveloperLB commented 4 years ago

So I suggest to update the main page of the repository then. :)

skydoves commented 4 years ago

Hi, it's updated.

https://user-images.githubusercontent.com/24237865/71962685-534a6600-323d-11ea-9e1e-df1f68cb2181.gif

I changed the first preview. 👍

AndroidDeveloperLB commented 4 years ago

I still see it for the second and third : https://github.com/skydoves/PowerSpinner