Closed andreas-umbricht closed 2 years ago
skydoves
commented
2 years ago Hi, thank you for describing the details.
I have two questions below:
1.5.3-SNAPSHOT?GlideImage or CoilImage?Thanks!
andreas-umbricht
commented
2 years ago When I use the same example with com.github.skydoves:landscapist-glide:1.5.2 everything works as expected. Thanks for the hint!
LazyVerticalGrid(
columns = GridCells.Fixed(3)) {
items(imageUrls.value) { imageUrl ->
Box(modifier = Modifier.aspectRatio(1f)) {
GlideImage(
imageModel = imageUrl,
contentScale = ContentScale.Crop
)
}
}
}
When I use the example with com.github.skydoves:landscapist-coil:1.5.2 it also takes forever to load the images, or they don't get loaded at all. At least it doesn't crash unlike Fresco.
Sadly, I wasn't able to test 1.5.3-SNAPSHOT. I tried implementation "com.github.skydoves:landscapist-fresco:1.5.3-SNAPSHOT". But all I get is Could not find com.github.skydoves:landscapist-fresco:1.5.3-SNAPSHOT. when trying to build the app.
If you can help me to get 1.5.3-SNAPSHOT working I will gladly also test Fresco, Coil and Glide with that. Until then, I will simply use Glide.
skydoves
commented
2 years ago Thank you for checking this!
You should add the repository URL below in your gradle.build file:
repositories {
maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' }
}You can see the instruction here: https://github.com/skydoves/landscapist#snapshot
andreas-umbricht
commented
2 years ago Ah, silly me. Thanks for the instruction.
Using 1.5.3-SNAPSHOT, Fresco does not crash anymore luckily, but Fresco and Coil still don't load all images or it takes ages to do so.
I think, I will stick with Glide for the moment.
skydoves
commented
2 years ago Thanks for checking the details. It seems a library issue for the Coil and Fresco, but let me debug the details and keep you updated on this. Thanks!
Describe the Bug:
When using a LazyVerticalGrid with following minimal example, the app crashes upon scrolling, when using more than 30+ image Items. I can't reproduce the crash with my Huawei P30 Pro which runs Android 11, so it could also be a Android 12 kind of problem. But even when I test on my Huawei P30 Pro device, the pictures, which are really not that big, are loaded very slowly.
Error message is:
To facilitate reproducing the error you can use the following images.
Expected Behavior:
When I use LazyColumn instead of LazyVerticalGrid everything works fine, so I expect a similar behavior just like when I use LazyColumn. Generally the photos are loaded much slower within a LazyVerticalGrid than in a LazyColumn.
I hope you can understand and reproduce my problem. If you need any more information, just ask.