search

skydoves / landscapist

🌻 A pluggable, highly optimized Jetpack Compose and Kotlin Multiplatform image loading library that fetches and displays network images with Glide, Coil, and Fresco.
https://skydoves.github.io/landscapist/
Apache License 2.0
2.15k stars 114 forks source link

Landscapist runtime crash with beta 08. #25

Closed Vivecstel closed 3 years ago

Vivecstel commented 3 years ago

Please complete the following information:

Describe the Bug:

After updating the compose dependency to 1.0.0-beta08, all landscapist libraries (CoilImage, GlideImage, FrescoImage) crash at runtime with the following stackrace:

ava.lang.NoSuchFieldError: No field Clamp of type Landroidx/compose/ui/graphics/TileMode; in class Landroidx/compose/ui/graphics/TileMode; or its superclasses (declaration of 'androidx.compose.ui.graphics.TileMode' appears in /data/app/~~lPHkKeaVkTN6BDFdaohwwA==/com.steleot.jetpackcompose.playground-sSgRla-zZWCVDMLEPvKzFg==/base.apk)
        at com.skydoves.landscapist.Shimmer__ShimmerKt$Shimmer$2.invoke(Shimmer.kt:102)
        at com.skydoves.landscapist.Shimmer__ShimmerKt$Shimmer$2.invoke(Shimmer.kt:79)
        at androidx.compose.ui.draw.DrawBackgroundModifier.draw(DrawModifier.kt:101)
        at androidx.compose.ui.node.ModifiedDrawNode.performDraw(ModifiedDrawNode.kt:102)
        at androidx.compose.ui.node.LayoutNodeWrapper.draw(LayoutNodeWrapper.kt:249)
        at androidx.compose.ui.node.ModifiedLayoutNode.performDraw(ModifiedLayoutNode.kt:82)
        at androidx.compose.ui.node.LayoutNodeWrapper.draw(LayoutNodeWrapper.kt:249)
        at androidx.compose.ui.node.LayoutNode.draw$ui_release(LayoutNode.kt:800)
        at androidx.compose.ui.node.InnerPlaceable.performDraw(InnerPlaceable.kt:116)
        at androidx.compose.ui.node.LayoutNodeWrapper.draw(LayoutNodeWrapper.kt:249)
        at androidx.compose.ui.node.ModifiedLayoutNode.performDraw(ModifiedLayoutNode.kt:82)
...

Expected Behavior:

CoilImage, GlideImage, FrescoImage should not crash with compose beta 08 version

skydoves commented 3 years ago

Hi, @Vivecstel 1.2.3-SNAPSHOT has been released and 1.2.3 stable will be released soon. Thanks!

Vivecstel commented 3 years ago

@skydoves I have some issues with the fresco dependency. I will check later today if I am ok. Thanks :)

Vivecstel commented 3 years ago

Thanks @skydoves . 1.2.3 seems ok.

skydoves commented 3 years ago

Thanks for checking!