search

skyfielders / python-skyfield

Elegant astronomy for Python
MIT License
1.39k stars 209 forks source link

Load deepsky objects from pyongc #824

Open mattiaverga opened 1 year ago

mattiaverga commented 1 year ago

Loading deepsky objects from pyongc is possible in two ways: a simple load using Star.from_ongc('identifier') or by converting a dataframe from pyongc.data with skyfield.data.ongc.load_dataframe() + Star.from_dataframe() for loading several objects at once. The pyongc dependency is optional (users needs to install skyfield[ongc] extra to pull in pyongc dependency).

Fixes #823

mattiaverga commented 1 year ago

I've pushed the requested changes, let me know if it's now ok.

brandon-rhodes commented 1 year ago

I've pushed the requested changes, let me know if it's now ok.

Thanks for the update! I am about to travel to a Python event, which might delay my review, but this issue is at the top of my list for when I get back home, so stay tuned—I'll be careful not to merge any other code until I've had the chance to look this over again. 🙂