skyfishjy / android-ripple-background

A beautiful ripple animation for your app
MIT License
2.26k stars 579 forks source link

rippleStrokeWidth not used in Stroken Ripple Type #24

Open tudoubudou opened 8 years ago

tudoubudou commented 8 years ago
@@ -79,8 +79,10 @@ public class RippleBackground extends RelativeLayout{
         if(rippleType==DEFAULT_FILL_TYPE){
             rippleStrokeWidth=0;
             paint.setStyle(Paint.Style.FILL);
-        }else
-        }else{
-            paint.setStrokeWidth(rippleStrokeWidth);
           paint.setStyle(Paint.Style.STROKE);
-        }
       paint.setColor(rippleColor);
ghost commented 8 years ago

Confirmed, I also spent time looking what I did wrong so the ripple is always 2dp but it seems that the issue is in the library.

drorGlucome commented 5 years ago

hey do you have an update relating the stroke width issue?

tudoubudou commented 5 years ago

@drorGlucome check out my modification "-" means remove the current line

drorGlucome commented 5 years ago

Thank you for the answer. So only way is to download the code modify and use as static lib?

tudoubudou commented 5 years ago

Thank you for the answer. So only way is to download the code modify and use as static lib?

yes