skyflynil / stylegan2

StyleGAN2 - Official TensorFlow Implementation with practical improvements
http://arxiv.org/abs/1912.04958
Other
120 stars 33 forks source link

Reintroduced close() to dataset.py #19

Closed arpastrana closed 3 years ago

arpastrana commented 4 years ago

Hello. TheTFRecordDataset() no longer has a close() method which is required in line 367 of training_loop.py. This raises an error once the user-defined number of kimgs is reached and the training session is over. This method was there in the original Nvidia's implementation but removed since 54b68ea49c357416500ce63853544111222af915. My guess is that users seldom reach the end of the training loop, so the error is not encountered that often. However, I propose to add this back for completeness and future compatibility. Thank you.