search

skyguy126 / Xposed-SoundCloudDownloader

Download songs directly from the SoundCloud app.
GNU General Public License v3.0
39 stars 14 forks source link

suggestion [adding cover artwork +id3 tags to the mp3 file ] #11

Closed waelchateur closed 6 years ago

waelchateur commented 6 years ago

can u please add auto id3 tags and artwork feature to ur project

skyguy126 commented 6 years ago

this might be a delayed feature, I'm trying to find a nice library for mp3 tags.

waelchateur commented 6 years ago

https://sites.google.com/site/eternalsandbox/myid3-for-android

waelchateur commented 6 years ago

take a look at that maybe will help

waelchateur commented 6 years ago

https://github.com/mpatric/mp3agic

skyguy126 commented 6 years ago

That was the first one I tried actually. It doesn't compile in android for some reason. I think its due to how it needs java 1.8 to run.

waelchateur commented 6 years ago

did u see this https://github.com/hexise/jaudiotagger-android

master801 commented 6 years ago

@skyguy126 Why do you want to avoid using Java 8? Is it for backwards-compatibility in Android?

skyguy126 commented 6 years ago

Android only supports a small subset of features in java 8. The ones required by the library are not and this leads to compilation failure.

skyguy126 commented 6 years ago

Update: Found a tagging library and everything is working well so far. Code needs to be refactored and a few things need to be stabilized still.

skyguy126 commented 6 years ago

Added with c47bed25cee45be5b7f4346d285951f051ba0500. Will require more testing before release.

waelchateur commented 6 years ago

Just wow 😍 well done bro its works flawlessly .... i was waiting for something like this thank you and good luck on your projects ...... thanks a lot 👌