Open cleversboy opened 5 years ago
Can you post the full xposed log?
10-12 21:04:18.187 I/Xposed (10185): [SoundCloud Downloader] Entered download catcher... 10-12 21:04:18.187 I/Xposed (10185): [SoundCloud Downloader] Track name: [ 蘭陵王妃 ] 彼岸 ~ 董貞 10-12 21:04:18.187 I/Xposed (10185): [SoundCloud Downloader] Found genre data... 10-12 21:04:18.187 I/Xposed (10185): [SoundCloud Downloader] Image url: https://i1.sndcdn.com/artworks-000195063863-pcxdsk-t250x250.jpg 10-12 21:04:18.187 I/Xposed (10185): [SoundCloud Downloader] com.skyguy126.soundclouddownloader scd_prefs 10-12 21:04:18.197 I/Xposed (10185): [SoundCloud Downloader] Include metadata: false 10-12 21:04:18.197 I/Xposed (10185): [SoundCloud Downloader] Save location: 2 10-12 21:04:18.197 I/Xposed (10185): [SoundCloud Downloader] Download path: /storage/emulated/0/Music/[ 蘭陵王妃 ] 彼岸 ~ 董貞.mp3
And the file isnt there? Are you sure you're not having network issues, or anything like that. Can this issue be repliacted?
Nothing being downloaded as notification show" download unsuccessful". I even disable everything I can. all other module, reboot multiple times. I can manually get soundcloud link with my computer and download with my phone.
What version of soundcloud and scd are you running?
...
Fixed with db356f9bf65dc7b7194a79374edf5bda6bb786c3. Please re-open this issue if you are still having issues.
10-15 17:52:52.801 I/Xposed ( 9515): [SoundCloud Downloader] Entered download catcher... 10-15 17:52:52.801 I/Xposed ( 9515): [SoundCloud Downloader] Track name: Rocket Girls (火箭少女101) - Light 10-15 17:52:52.811 I/Xposed ( 9515): [SoundCloud Downloader] Found genre data... 10-15 17:52:52.811 I/Xposed ( 9515): [SoundCloud Downloader] Image url: https://i1.sndcdn.com/artworks-000419000433-9jba5v-t250x250.jpg 10-15 17:52:52.831 I/Xposed ( 9515): [SoundCloud Downloader] SDK < 23, permissions must be granted manually? 10-15 17:52:52.841 I/Xposed ( 9515): [SoundCloud Downloader] com.skyguy126.soundclouddownloader scd_prefs 10-15 17:52:52.851 I/Xposed ( 9515): [SoundCloud Downloader] Include metadata: false 10-15 17:52:52.851 I/Xposed ( 9515): [SoundCloud Downloader] Save location: 2 10-15 17:52:52.851 I/Xposed ( 9515): [SoundCloud Downloader] Download path: /storage/emulated/0/Music/Rocket Girls (火箭少女101) - Light.mp3 10-15 17:52:52.911 I/Xposed ( 9515): [SoundCloud Downloader] Download Error: need WRITE_EXTERNAL_STORAGE permission to use DESTINATION_FILE_URI: uid 10203 does not have android.permission.WRITE_EXTERNAL_STORAGE.
You have to enable storage permissions for the Soundcloud app. Also this app is mainly supported for SDK 23+ (Android Marshmallow+) so that may cause issues as well.
I implemented a permissions hack in the latest version which is only meant for Android 6.0+. If you are experiencing issues on a lower Android version, you might want to roll back SCD and Soundcloud for the time being.
I try to add these to SoundCloud manifest: `
` And agian, log shows file downloading but Download manger keep failing.
How did you add them? What android version are you running. If Android 6+ then the module will automatically inject those permissions at runtime.
I use apktool (decompile, recompile) Android 5.0.2
Can you make an option to get song's link or choosing other 'downloader' apps?
What I can do is just spit the link out in the Xposed Log. I don't think I'll add a feature to choose other apps because it'll be too hard to maintain with updates. The module has a lot of code as is and its getting a bit annoying to reverse engineer the code with every update.
Hook OK, Xlogs look just fine: Entered download catcher... ... Download path:/vvv/vvv.mp3 BUT... when I try downloading any songs, Download manager just show up a sec then disappear then show up then disap... And finally, It shows "Download unsuccessful" Soundcloud 2018-02-07 release