Introducing message transforming

skyhop / Mail

A library smoothing email generation from .NET code, by enforcing a strong boundary between the template, and code rendering the template.

Apache License 2.0

11 stars 2 forks source link

Introducing message transforming #11

Closed synercoder closed 4 years ago

synercoder commented 4 years ago

Replaces idea brought up by #10

corstian commented 4 years ago

@ajbeaven, does this API set make sense to you?

ajbeaven commented 4 years ago

Love your work! All makes sense to me.

You'll have to clearly outline the use cases for both transform delegates and I would perhaps suggest not using terminology around, and making a distinction between, rendering and sending. Since both happen inside the one - now two - public methods, this seems to me like an internal implementation detail so I'm not sure how worthwhile it is burdening the consumer with this insight.

synercoder commented 4 years ago

@ajbeaven Good call, removed the mention of rendering in the XML comment

corstian commented 4 years ago

I've ran a few tests and everything seems to be working smoothly. The rc4 package has just been published over at https://www.nuget.org/packages/Skyhop.Mail/3.0.0-rc4, and will be available shortly. Thanks for the contributions!