Hebrew Vowels Displaying Incorrectly

skyjake / lagrange

A Beautiful Gemini Client

https://gmi.skyjake.fi/lagrange/

BSD 2-Clause "Simplified" License

1.19k stars 62 forks source link

Hebrew Vowels Displaying Incorrectly #521

Open ghost opened 2 years ago

ghost commented 2 years ago

It looks like Hebrew vowels and chant markers are displaying incorrectly in lagrange:

This is how it should look:

While these markers are not used most of the time for Modern Hebrew, they are necessary for Scriptures and religious texts (the Bible, prayerbooks, etc.), they can be used when vowels cannot be assumed (like with names), and sometimes they are used to help beginners and children learn Hebrew.

I have a test file here: gemini://auragem.space/devlog/test.gmi

skyjake commented 2 years ago

Probably the same issue as in #345 and #463: the HarfBuzz script is not being set according to the Unicode code points.

ghost commented 2 years ago

While this is being looked into, it might also be good to make sure Arabic and Farsi's vowel points work as well.

... I took a quick look at arabic and I don't think it's 100% correct either, but I'm not sure.