search

skyjake / lagrange

A Beautiful Gemini Client
https://gmi.skyjake.fi/lagrange/
BSD 2-Clause "Simplified" License
1.19k stars 62 forks source link

webp support #657

Closed d47081 closed 6 months ago

d47081 commented 6 months ago

Is webp supported?

I found few closed issues but with version 1.17.6 this does not work

2024-03-12_18-42

skyjake commented 6 months ago

WebP is supported, however it is an optional build dependency. I have included WebP decoding in most of the binaries available here on GitHub and in the mobile builds.

Which build are you running?

d47081 commented 6 months ago

Hm, I don't remember, suppose the build from this repo, master branch - it's correct?

Doubts maybe the app issue, but image/png works well there, e.g. gemini://kevachat.duckdns.org/raw/NZGczWYDgewMqLm5PL5STiwbX5UJN5XD42

Could you please check this image/webp one on your build: gemini://kevachat.duckdns.org/raw/NQdN6x4g4tEXRp3M6yfQdqqoZHUkS4bbs3

Maybe just incorrect meta headers / MIME type..

p.s. I'm using build on Debian 12, i3wm so also maybe I forgot to install some dependency to support this format in system environment, just not sure how does it work exactly, seems it work before (on Ubuntu), but now I can't open.. maybe not browser issue

skyjake commented 6 months ago

The binaries are built out of the "release" branch but currently the main branch is pretty much equivalent to release.

Your linked image does work for me (in the iOS mobile build, at least): Screenshot 2024-03-12 at 21 16 25

d47081 commented 6 months ago

Hm, thanks.. let me check it from release binaries, maybe that's really some system dependency that I forgot to install (because webp is ~newest format, maybe just debian want some lib to render that inline)

d47081 commented 6 months ago

Yes, it works in appimage

I found that forgot to compile with ENABLE_WEBP:

cmake . -DCMAKE_BUILD_TYPE=Release -DENABLE_WEBP=YES

Just why not to enable webp by default?