skyl / corpora

Corpora is a self-building corpus that can help build other arbitrary corpora
GNU Affero General Public License v3.0
2 stars 0 forks source link

update(gpt): try to change to 4o #4

Closed skyl closed 1 month ago

skyl commented 1 month ago

PR Type

configuration changes


Description


Changes walkthrough ๐Ÿ“

Relevant files
Configuration changes
.pr_agent.toml
Add configuration for GPT model version                                   

.pr_agent.toml
  • Added a new configuration file .pr_agent.toml.
  • Set model, model_turbo, and fallback_models to gpt-4o.
  • +4/-0     

    ๐Ÿ’ก PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    github-actions[bot] commented 1 month ago

    PR Reviewer Guide ๐Ÿ”

    (Review updated until commit https://github.com/skyl/corpora/commit/6aecd8c9102a9332eda66d910feac891fdd63afc)

    Here are some key observations to aid the review process:

    โฑ๏ธ Estimated effort to review: 1 ๐Ÿ”ตโšชโšชโšชโšช
    ๐Ÿงช No relevant tests
    ๐Ÿ”’ No security concerns identified
    โšก No major issues detected
    github-actions[bot] commented 1 month ago

    PR Code Suggestions โœจ

    Latest suggestions up to 6aecd8c Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Correct potential typos in the model names to ensure the configuration refers to the correct models ___ **Ensure that the model names are correctly specified. The model name "gpt-4o" might
    be a typo and should be "gpt-4".** [.pr_agent.toml [2-4]](https://github.com/skyl/corpora/pull/4/files#diff-356a4c0b1558da9e4be849aa64f19af78488ec6819f379e21ae93c53e750fbe7R2-R4) ```diff -model = "gpt-4o" -model_turbo = "gpt-4o" -fallback_models = ["gpt-4o"] +model = "gpt-4" +model_turbo = "gpt-4" +fallback_models = ["gpt-4"] ```
    Suggestion importance[1-10]: 8 Why: The suggestion addresses a potential typo in the model names, which could lead to misconfiguration or errors if the specified model "gpt-4o" does not exist. Correcting this to "gpt-4" is crucial for ensuring the configuration is accurate and functional.
    8

    Previous suggestions

    Suggestions up to commit 115be61
    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Verify and correct the model names to ensure they are configured correctly ___ **Ensure that the model names are correctly specified and match the available models
    in the system. The repeated use of "gpt-4o" for both model and model_turbo might be
    a typo or misconfiguration.** [.pr_agent.toml [3-4]](https://github.com/skyl/corpora/pull/4/files#diff-356a4c0b1558da9e4be849aa64f19af78488ec6819f379e21ae93c53e750fbe7R3-R4) ```diff -model = "gpt-4o" +model = "gpt-4" model_turbo = "gpt-4o" ```
    Suggestion importance[1-10]: 7 Why: The suggestion highlights a potential misconfiguration by using the same model name for both `model` and `model_turbo`, which could be an oversight. Correcting this could prevent configuration errors, making it a relevant and useful suggestion. However, it is not certain that this is an error, so the score reflects its potential impact rather than certainty.
    7
    github-actions[bot] commented 1 month ago

    Persistent review updated to latest commit https://github.com/skyl/corpora/commit/6aecd8c9102a9332eda66d910feac891fdd63afc

    skyl commented 1 month ago

    /ask "can you write me a short poem about this PR written as William Shakespeare?"

    github-actions[bot] commented 1 month ago

    Askโ“

    can you write me a short poem about this pr written as william shakespeare?

    Answer:

    Upon this parchment, new configurations lie,
    To guide the models with a gentle hand,
    In toml's script, the settings now comply,
    With "gpt-4o" across the land.

    The models, turbo, and fallback aligned,
    In harmony, they speak with one accord,
    A change in code, with purpose well-defined,
    To elevate the wisdom they afford.

    Thus, in this file, the future is inscribed,
    A testament to progress, bold and bright,
    Where once was chaos, order is prescribed,
    And in this change, we find our guiding light.