search

skylarmt / android-xserver

Automatically exported from code.google.com/p/android-xserver
0 stars 0 forks source link

ZPixmap of depth 1 is not handled correctly, crashes gnome-terminal #10

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Run gnome-terminal on the android-xserver.
2.
3.

What is the expected output? What do you see instead?
Expect 'normal' execution, instead an Error is sent as size of resource is 
incorrectly calculated. (calculated as 3*width*height bytes when the resource 
sent by gnome-terminal is width*height/8 bytes). I have no idea if this is 
correct behaviour by gnome-terminal but everything seems to run correctly when 
the following line is changed: 

http://code.google.com/p/android-xserver/source/browse/XServer/src/au/com/darksi
de/XServer/Drawable.java#885

Line reads:
                        if (depth != 32 || leftPad != 0)

To fix this, change to:

            if ((depth != 32 && depth!=1) || leftPad != 0)

The following code to handle a Bitmap will also handle this ZPixmap with depth 
of 1.

Original issue reported on code.google.com by comms.me...@gmail.com on 21 May 2012 at 9:12

GoogleCodeExporter commented 8 years ago 
This may be a duplicate of issue 8... Certainly sounds like it to me, the fix 
may cure both.

Original comment by comms.me...@gmail.com on 21 May 2012 at 9:14

GoogleCodeExporter commented 8 years ago 
Fixed in release 1.11

Original comment by matti.k...@gmail.com on 25 Aug 2013 at 10:35